[SYCL][UR] Update setErrorMessage to use int32_t instead of ur_result_t for the urAdapterGetLastError entry point #18264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
changed the title
…urAdapterGetLastError entry point.
…tError is no longer used for warnings.
martygrant
force-pushed
the
martin/correctSetErrorMessageParam
branch
from
cf0a410 to
ac16a81
Compare
martygrant
force-pushed
the
martin/correctSetErrorMessageParam
branch
from
5a8c0a8 to
6a5663a
Compare
aarongreig
reviewed
May 2, 2025
aarongreig
approved these changes
May 2, 2025
npmiller
approved these changes
May 2, 2025
kbenzie
reviewed
May 5, 2025
Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
hvdijk
reviewed
May 5, 2025
| @@ -11,21 +11,14 @@ | |||
| #include "common.hpp" | |||
|
|
|||
| // Global variables for UR_RESULT_ADAPTER_SPECIFIC_ERROR | |||
| // See urGetLastResult | |||
| thread_local ur_result_t ErrorMessageCode = UR_RESULT_SUCCESS; | |||
| thread_local int32_t ErrorMessageCode; | |||
There was a problem hiding this comment.
In other adapters you keep the initialization but change it to zero, here you drop the initialization, presumably it should also be kept here?
There was a problem hiding this comment.
yes it should, I've updated it now thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18260
Also updates
checkUrResultin SYCL RT to remove warning level check asurAdapterGetLastErroris now only used for errors.